Upload
webexpo
View
579
Download
1
Tags:
Embed Size (px)
DESCRIPTION
"What's the value of code reviews and how you can do them in Phabricator." More at http://webexpo.net/prague2013/talk/code-reviews-with-phabricator/
Citation preview
Code Reviews with PhabricatorJakub Vrána, WebExpo 2013
PhabricatorStarted as Diffcamp at FacebookOpen sourceUsers: Dropbox, Asana, Quora, Uber, …Supports Git, Mercurial, SVN, plain diffsFor developers from developersPerforms at scaleOther tools: GitHub, Critique, …
Phabricator ApplicationsDifferential: code reviewsDiffusion: browse repositoryManiphest: tasks and bugsHerald: notifications
Owners, Calendar, Wiki, Blog, lots more
Conduit: APIArcanist: command line interface
Differential: Code, Context
Demo
Differential: Inline comments
Demo
Differential: Cross-references
Demo
Differential: Copies, Moves
Demo
Diffusion: Stable Links
Diffusion: Blame Previous
Demo
Maniphest: “Not Bad”
Herald: Packages
Calendar: Reviewer Away
Conduit: Method Call
Arcanistarc feature: Start working on somethingarc diff: Send code for reviewarc land: Publish reviewed code
arc cover: Who should review my changearc patch: Apply someone’s revisionSeveral other commandsWorks on Linux, Mac, Windows
Arcanist: Lint
Arcanist: Unit Tests
Test plan
CustomizationConfigurationExtending code
Differential fieldsRemarkup rulesEvents
Custom Arcanist commandsConduit
WeaknessesCommit discovery is delayedSome features require manual setup
E.g. cross references
Hosted repositories should solve both
CultureResponse within a dayDon’t ask for unrelated changesExpress strength of your feelingsWho reviews the codeWho lands the codeHow is the code testedWhen is the code linted and testedPre-commit or post-commit review
Thanks