mdo opened this pull request 5 months ago WIP: Bootstrap 3€¦ · o Similar to the default grid system, ... Typography in Bootstrap 3 isn't seeing much change, just a decent amount

From github.com/twitter/bootstrap/pull/6342 1 23 May 2013

Copied 23 May 2013

mdo opened this pull request 5 months ago

WIP: Bootstrap 3

To better illustrate how we'll be developing in the future, we're using this pull request for Bootstrap 3. In the future, this will be feature-specific (e.g., a branch like 3.1.0-modal-revamp instead of n.n.n-wip).

While our last major version bump (2.0) was a complete rewrite of the docs, CSS, and JavaScript, the move to 3.0 is equally ambitious, but for a different reason: Bootstrap 3 will be mobile-first. This is an ongoing document to identify the changes we'll be making along the way. Docs


We'll be working to simplify the content of the docs once again. Key changes are around the organization of the pages and the tools powering them.

General docs changes

• Move docs to be only in the gh-pages branch.

o Instead of all our docs content—homepage, docs, customizer, and templates—being in master, they will be in gh-pages only.

o Reason #1: Not everything needs to be immediately available to everyone. Docs, and all their supporting assets, get in the way of folks who just want to use CSS and JS.

o Reason #2: The docs are now built on Jekyll (see next major point) and are thus not immediately available upon download. You need to install Jekyll and it's dependencies, and that's not something we should force everyone to do. Nor should we give them the impression that the docs are immediately usable.

o Reason #3: This effectively nukes tens of thousands of lines of code from the master branch.

o Reason #4: The docs are still hosted and available to all, when v3 launches, at http://getbootstrap.com.

• Host previous versions of documentation.


o Instead of having folks download release tags, we'll go back and add the docs for the most recent version (2.3.1) to the site. They'll be available at http://getbootstrap.com/2.3.1/docs once v3 goes live.

• Convert docs to Jekyll. o Instead of Mustache, docs templates are built with Jekyll.

o This greatly simplifies deploying docs changes, isolates our docs from CSS and JavaScript changes, and drastically decreases the amount of code being tracked in the repo.

o It also provides better URLs, page title variables, partials, and code highlighting.

• Add "Customizing Bootstrap" section to detail best practices for customizing CSS.

• Remove all i18n tags from Mustache templates. No more {{_i}} and {{/i}} in the docs templates, just raw HTML in our Mustache files.

• Remove Extend page because it's content was not directly applicable to Bootstrap and out of date with info in the readme and Getting Started page.

Readme updates

• Started list of "Bootstrap elsewhere" links for documenting popular implementations of Bootstrap within other services, e.g. Roots starter WordPress theme.

• Reordered readme to punt the license file text and simply link to the license file.

Homepage

• Point link to the new Bootstrap Expo.

• Remove examples and basically all marketing content from homepage.

Getting started

• Add Bower installation instructions to guide.

• Add new Customization best practices section.

Example templates

• Update all examples to reflect changes in markup and mobile-first push.

Global JavaScript

• Overhaul CSS transitions and reinforce with JavaScript transitions as necessary.

• Improve noConflict throughout plugins.


• Namespace events to reduce conflict issues.

• Drop bootstrap-typeahead.js. o For context, see 88dd9de. o Instead, use Twitter's typeahead.js plugin.

Global CSS

At a high level, we're dropping IE7 and FF3.6 support, combining standard and responsive CSS into a single file, and consolidating additional code as appropriate.

Browser support

• Drop support for IE7. Removed all * hacks, such as *zoom: 1;, and other IE7-specific lines of CSS.

• Drop support for Firefox 3.6. Removed -moz-box-shadow instances and related hacks.

LESS changes

• Refactor components to be more mixin-friendly.

o Instead of all component classes being a hodgepodge of un-nested CSS, we'll re-order the code to make it super easy to take any Bootstrap class and use it as a mixin.

• Rename variables to use dashes instead of camelCase. For example, it's now @body-bg instead of @bodyBackground.

• More consistent variable naming scheme.

o The format of variables was all over the place and has now been standardized.

o The general approach is element, state, pseudo state. For example, @navbar-link-color-hover.

• Replace existing color variables with more semantic ones.

o No more @blue, @orange, and the like, which we weren't using them much anyway.

o They've been replaced with @brand-primary, @brand-success, and others. These are then assigned on a per-component basis (e.g., @state-warning-text, @btn-background-primary, etc).

o Also removed @black and @white because #000 and #fff are 20% shorter and not something that should be controlled via variable.

• Remove .border-radius() and .border-*-*-radius mixins.

o As only Android 2.1, iOS 3.2, and older desktop browsers require a prefixed version, we've removed the base mixin. Since we no longer require prefixes for independent corners, we've dropped those mixins as well. Mixins for a single side, like .border-left-radius, are still available.


• Use decimal values in .opacity() mixin instead of whole numbers to match default CSS patterns.

o For example, write .opacity(.5) instead of .opacity(50).

• Add retina image mixin. Declare a standard and 2x image path and set the size for easy retina images anywhere.

• Add new global @component-active-bg variable.

o Instead of assigning @link-color to multiple variables for backgrounds, we have dedicated a new variable to that.

o Change @component-active-bg and customize the active states of nav pills, dropdowns, and more.

Miscellaneous

• Go mobile first. Responsive CSS is no longer separate and all responsive features are now compiled into the core bootstrap.css file near. Separate files are no longer required, and have thus been removed.

• Upgrade to latest Normalize, and removed reset.less.

o This includes removing reset.less in favor of a dedicated normalize.less file.

o Print styles and responsive image CSS (the only meaningful modifications from the previous reset file) have been moved to print.less and scaffolding.less, respectfully.

• Moved print styles to separate print.less file.

o Previously print styles were bundled with the scaffolding.less page.

o Now within a separate file for easy removal via the Customizer.

• Remove layouts.less.

o Since it only held a couple layout styles and the fluid container has been removed (see next section), this file is superfluous.

o We've moved the default .container styles to grid.less.

• Add !important to .hide and .show.

o For these classes to work on every element, the specificity either needed to be higher or we needed the !important flag. We opted for the latter for fewer lines of code.

• Drop *-important for .*-danger.

o Some elements had red variations that came from different class naming schemes, so we standardized that by switching all red variations to *‐danger.

o Includes buttons, labels, badges, text, alerts. and progress bars.

• Refactor responsive utility classes to match new media queries.

• Confirm no lingering "TODO" comments in the source code. o [ ] Refactor .dropup and bottom navbars for a single class?


o [ ] Double check height of <select> elements in IE8

o [ ] Consider !important on float utility classes

Grid system

The grid is drastically simpler, yet more powerful, in BS3. We're transitions back to a single grid system, but with all the awesomeness that was present in the old grids. On top of that, we've also added some new features.

• Overhaul grid systems to make it fluid and mobile first.

o Removed the separate fluid grid system, container, and layout as we're down to one grid.

o New single grid system (still uses .row) utilizes percentages over pixels, padding instead of margin, and box‐sizing: border‐box for easy math.

o The grid is mobile first, meaning it starts out stacked and scales up as necessary to become horizontal via media queries. Previously the grid was built for 940px layouts and scaled up and down.

o Nesting is still 100% supported, but columns will be proportionately sized to their parent, just as the old fluid grid behaved.

o Offsets are still 100% supported.

• Increase specificity of grid classes.

o Instead of .span* and .offset*, we're now using .col‐span-* and .col-offset-*.

• Simplify required grid variables.

o The @grid‐row‐width and @grid‐column‐width variables have been removed. We didn't use the row width (@gridRowWidth as of v2.3.1) variable anywhere in the source and column widths are now derived via simple calculations in our LESS.

o We've added a new @grid-float-breakpoint variable to customize the point at which the floats and widths kick in for our new mobile-first grid.

• Add small grid system for phones and mini tablets.

o Similar to the default grid system, we've added a 12 column small device grid with separate classes from the default responsive grid.

o At screen sizes of 767px or less, use .col‐small‐span‐* to create mobile-only layouts.

• New and improved grid mixins.

o Changed .makeRow() to .make‐row().

o Changed .makeColumn() to .make‐column(). In addition, it includes a media query to apply the float and width when above the @grid‐float‐breakpoint value.

o Added .make‐column‐offset() to generate column gaps, similar to the predefined grid classes.


• Add .push* and .pull* modifier classes for easy column source ordering.

• Remove dedicated table grid classes.

o They are no longer necessary given the new grid.

o However, we are still removing the float on .col‐span‐* classes when used within .table elements.

• Remove dedicated input grid classes.

o Remove input grid mixin and input span classes.

o Given new grid system, inputs are always width: 100%; to start.

o Best practices now are to place 100% wide inputs within grid columns as opposed to using classes directly on input elements.

• Use max-width instead of width on all .container instances to help prevent some issues with containers in components like navbars.

Type

Typography in Bootstrap 3 isn't seeing much change, just a decent amount of cleanup and some small improvements.

Headings

• Add support for headings classes (e.g., h1, .h1 { … }).

• Remove text-rendering: optimizeLegibility from headings to prevent (inconsistent) broken rendering on some Android and Windows devices.

Lists

• Change ul.unstyled to .list-unstyled.

o No longer dependent on HTML element in the selector.

o Can now be used as mixin.

• Change ul.inline to .list-inline.

o Uses .list-unstyled as a mixin to reset default list styles.

o Can now be used as a mixin.

Text classes

• Changed .muted to .text-muted to match the other contextual text colors.

• Fixed bug with text alignment utility classes and tables.

LESS


• Remove all #font mixins.

o We only used these in one place and they honestly just complicated things.

o Instead of using mixins, just make use of the @font‐family‐ variables.

• Drop the @altFontFamily variable.

We explored the use of rem units over pixels, but found little benefit to offset the implications of their use. IE8 would still need a pixel fallback, and that's a lot of duplicate lines of code. Moreover, using rems everywhere instead of pixels would exacerbate that problem. Mixing rems and pixels doesn't seem to make sense either right now. However, we can and will continue to evaluate this in future releases.

Tables

• Remove table.info from table state classes.

• Added global text-align: left; for <th> elements (to undo the default center alignment) and removed font-weight: bold; from them (bold is a browser default).

• Improve nesting by scoping all styles to immediate children. o Using the > selector, we scope all styles. o Doesn't change much, but does mean you'll need to apply the table classes to all

nested tables.

Images

• Consolidate image thumbnail styles. No more .img-polaroid as it duplicated the same styles as .thumbnail. Now you can use .img-thumbnail for regular inline(-block) images, or .thumbnail for composite components.

Buttons

Fewer, but better buttons. They're redesigned and we're removing some from the mix because they have no clear and universal semantic purpose.

• Default button now requires .btn-default class.

o The default gray button requires two classes—class="btw btn-default".

o This better matches all our other buttons as well.

o We tried to remove the .btn class as well, but given the CSS for creating button groups and dropdowns, it's much simpler to keep it around.

o While it does add an extra class, it's specificity great simplifies customization methods in plain CSS, and even more so when extending those classes with LESS mixins.


• Drop .btn-inverse as there really is no semantic reasoning for adding it.

• Revamp some of the aesthetics of the buttons (no more outer box-shadow) by default.

• Simplify button mixins and pseudo states.

o Removed the .buttonBackground() mixin since it was no longer in use.

o Added the .btn‐pseudo‐states() mixin for setting button background‐color and border‐color for the default and :hover, :focus, :active, and various disabled states.

• Add justified button group option for link buttons. This feature is only available for buttons with link tags, e.g. <a href="#" class="btn">Button</a>, and is not compatible with the <button> element due to some browser lame-itude that keeps buttons from accepting auto widths on table-cell buttons.

We know folks have used .btn-inverse, but there is honestly no reason for it to be part of the core repo as it serves very little purpose other than "to be different." Including something for that reason isn't what we want to reinforce moving forward, so it's been nuked.

We had previously removed .btn-info for a couple weeks, but it has since been fully restored.

Forms

Form controls are now 100% width by default, input groups have been overhauled, and form states simplified.

• Update box model for inputs.

o Switched to box‐sizing: border‐box; and width: 100%; by default for all textual inputs.

o This means you'll need to specify a size for inputs, whereas before 3.0 inputs had a set pixel width (around 220px) to start.

• Remove input-prepend and input-append for singular .input-group. The classes have changed for the elements within, and require a bit more markup to use buttons.

o Use .input-group as the parent class around the input and addon.

o For text based prepends/appends, use .input‐group‐addon instead of .addon.

o For button prepends/appends, use .input‐group‐btn and place your .btn within that element.

• Drop .form-search.

• Add support for fieldset[disabled]. All form controls within a <fieldset> with the disabled attribute will be styled appropriately.


• Drop cursor: pointer; from labels and instead only set them on checkbox and radio label options.

• Drop .controls-row for grid inputs.

o Given input elements in 3.0 are set to width: 100% by default, and since we don't want to implement a separate input grid, we've opted to drop the .controls-row functionality.

o Instead, folks should wrap inputs in standard grid markup: with a wrapping .row and individual .span* columns around each input.

• Drop .input-block-level mixin and class.

o Since inputs are already width: 100%;, this is redundant.

o Note: inputs are still display: inline‐block, so if you absolutely need them to be block level, you'll need to independently set that yourself.

• Drop the .uneditable-input control. Instead, use a read-only input if you must.

• Horizontal forms are now mobile-first, meaning at <768px, elements are stacked. Above that, elements are floated and appear side-by-side.

• Checkboxes and radios now require an extra <div>.

o Instead of label.checkbox, you'll need div.checkbox with a <label> within.

o This was done to tighten up the clickable area around labels and avoid potential misclicks.

• New classes for inline radios and checkboxes.

o Instead of .radio.inline, you now need a single class, .radio‐inline, for direct use on a <label> element.

o To be clear, inline radios and checkboxes do not need a wrapping <div>, but the default stacked ones do.

• Added new placeholder syntax to the .placeholder() mixin for Firefox 19+.

• Allow form field states to apply to individual inputs.

• Separate single button dropdowns from segmented button dropdowns with unique classes.

• Still need to make button groups work within the new input groups (got some border-radius issues right now).

• Refactor .help-inline and .help-block for better support.

• Figure out form control margins in a better way. Right now we do a lot of overriding and perhaps form controls should have no margin to start.

Icons

• Font icons! Converted to Glyphicons v1.7 @font-face, dropping the old PNGs.

• New required base class.


o Instead of using an attribute selector, like [class^="glyphicon‐"], we now require a base class, .glyphicon.

o This improves general performance for larger pages while also increasing the durability of our code (as it doesn't enforce a specific order of classes).

o This is in addition to the prefix class (which has also been udpated).

• Updated class prefix for all icons: .glyphicon- instead of .icon-.

o We changed this for a more unique class, but also for consistency with the newly required base class as noted above.

Responsive utilities

• Refactor responsive-utilities.less to use new mobile-first approach.

• Update the docs to reflect the changes in media queries used.

Button groups

• Add support for dropdowns in button groups (or, nested button groups).

• Separate classes for regular button dropdown and segmented button dropdown.

• Update checkbox and radio variations to use actual checkbox and radio markup.

Labels and badges

We have differentiated the labels and badges with v3. The gist is that badges no longer have modifier classes and are purely meant as unread counters.

• Dropped all modifier variations on badges, making it as neutral as possible, much like those of Mail.app on OS X.

• Dropped the .label-inverse variation (in conjunction with the inverse button being removed).

• Refactor labels to scale with their parent's font-size.

Jumbotron (formly hero unit)

• Class changed from .hero-unit to .jumbotron. Associated variables have also been updated to match.

• Lighter font-weight for headings. Uses semibold instead of bold for headings.

• Scale font-size in responsive views.

• Now full-width without rounded corners to in mobile viewports.


• Improved type styles—now it starts with normal heading sizes and scales to larger sizes given a larger viewport.

Breadcrumbs

• Remove the trailing / from the last item.

Navigation

Navs

• Remove .nav-list option. Replaced by the new .list-group component.

• Remove tabs on left, right, and bottom.

o Tabs on the left and right, while occasionally useful, have been removed from our CSS.

o You can still use the JavaScript plugin and custom CSS to make left/right tabs, but we will no longer include those in the core.

• Removed parent <div> in the pagination component and dropped center and right alignment options. See #6562 for context.

Navbars

• Drop support for .navbar-search. We dropped the .navbar-search form layout, so it doesn't make sense to have this anymore. Also, this is just a slightly fancier .navbar-form, which we plan on keeping.

• Overhaul styles of default navbar and its sub-components:

o Dropdown menu carets (those attached to the actual menu, not the indicators) have been removed so that dropdown menus sit flat against the edge of the navbar.

o Navbar vertical dividers have been brought in a smidge, meaning they do not extend the full height of the navbar.

o No more box-shadow or gradients on the navbars.

o Height of navbar has increased from 44px to 62px for mobile devices, and 50px for desktops.

• Removed .navbar-inner and moved relevant styles to .navbar. The inner div is no longer required, greatly simplifying our shit.

• Changed .navbar > .nav to .navbar-nav.

• Change .btn-navbar to .navbar-toggle.


o More consistent naming schema

o Redesigned it a bit, lightening the styles and widening it, while also positioning it absolutely to the top right.

• Updated navbar brand component:

o Changed .brand to .navbar-brand for a more consistent naming schema.

o Center aligned .navbar-brand in mobile views, with a max-width: 200px; to limit hit area given a likely navbar toggle will be very near by.

• Dropped navbar dividers.

• Added support for disabled nav links. o Includes new variables like @navbar-link-color-disabled and @navbar-link-bg-

disabled, along with the inverse options.

• Update active state of nav links for mobile view.

• Improve non-nav links support in navbar. To date, we require .navbar-link and that's just bullshit.

• Improve forms and buttons support in navbar. There are lots of overrides, extra styles, and more, and that just sucks ass, too. Let's improve that.

Progress bars

• Add variables for background colors. Instead of hard-coded (and different) green, red, yellow, and blue colors, we use the new (more semantic) global colors.

• Refactor progress bar classes for simpler CSS.

o New structure is now .progress on the outer <div> and .progress‐bar on the inner <div>.

o Instead of placing modifier classes on the parent, they are placed directly on the bars (e.g., .progress‐bar‐info) in addition to the required .progress‐bar class.

Modals

• No longer require use of .hide. We updated the utility classes to use !important and to avoid clashing, removed the .hide class from modals. Now display: none; is set directly in the modals.less file. When upgrading, be sure to remove the .hide class from existing modals.

• Redesign the modals to be mobile-first.

o As BS3 is mobile-first, this new modal also starts at the mobile level and scales up via media queries.


o Reintroduces .modal‐open on the body (so we can nuke the scroll there)

o Adds a couple extra levels of markup (namely .modal‐dialog and .modal‐content) so we can scroll the entire modal rather than overflow a section within the modal.

o Related, .modal is now the wrapper, and .modal‐content is the modal itself. This is so we can still use position: fixed;, but make the modal relatively positioned so that scrolling moves the entire modal, not something with it.

o Added a .modal‐title for more consistent and useful targeting of the heading content (previously this was just an <h3> and selector performance wise that sucked).

• Explore adding two new sizing options, .modal-small and .modal-large.

• Test on iOS5. Not sure if we need to go older, but I want to check here to see how well fixed is supported.

• Test on Android devices (including native browser and Chrome). I only have a year-old Nexus lying around, so might need help tracking down bugs on older devices.

• Explore removing position: relative; from .modal-body to avoid some tooltip/dropdown/popover issues.

• Explore option to set width of the modal programmatically (instead of sizing options).

• Explore alternatives to stacking modals—perhaps a modal back button for piping in new content?

• Explore full-width modals for mobile with fixed modal headers for easier access to dismiss button.

• Check on body scrollbar and shifting content with overflow: hidden;.

Thumbnails

• Drop the .thumbnails meta component. Instead of special HTML and CSS for grid sizing, just use the grid system itself. Individual .thumbnail styles are still available, but for sizing, require a parent with a set width (e.g., grid columns).

Alerts

• <hr> elements within any .alert component will now be styled to match the border color of the alert.

• Immediate children links within default alerts, and within paragraph text, are now styled for improved readability. Links are automatically bolded and appear as a slightly darker color than the alert text.

New: List groups


Added a new component, the list group, for creating simple and complex series of components. Perfect for more complex implementations like email inboxes, or simple ones like a list of options.

• Requires .list-group as a parent base class (on a <ul>, <ol>, or <div>) • Requires .list-group-item for individual list items • List items can also be easily linked—just change from <ul class="list-group"> and <li

class="list-group-item"> to <div class="list-group"> and <a class="list-group-item">. • Option: include a badge, chevron, or both to any list item for automatic placement. • Option: use .list-group-item-heading and .list-group-item-text for custom content

implementations.

Linked list groups replace the nav list component.

List groups can also be used within panels with the .list-group-flush class to take them the full width of the parent panel.



New: Panels

Added a new component, the panel, for easily containing content within a box with an optional heading. Also included are contextual state classes for success, warning, danger, and info.


Carousel

• Redesign! Lighter styles for the previous and next controls, as well as the carousel captions.

• Update required markup for carousel controls. The .carousel-control class now requires another element within it for the previous/next characters. Those characters are now Glyhpicons icons for improved styling and positioning across browsers and devices.

• Indicators are now bottom-middle aligned.

• Captions are reinforced as optional and, by default, are hidden on mobile views, then shown for >768px viewports.

Customizer

• Redesign the entire thing.

• Highlight dependencies between components and assets.

• Figure out how to load and download the same customizations.

Makefile


Updated and simplified to better reflect the changes to the docs build process (namely Jekyll). It has also be redesigned (in as much as text can be). "Done" messages are also more real-time, showing only after the step has been completed (see #6968).

Good to merge — The Travis CI build passed (Details)

Documents

mdo opened this pull request 5 months ago WIP: Bootstrap 3€¦ · o Similar to the default grid system, ... Typography in Bootstrap 3 isn't seeing much change, just a decent amount